drivers: ethernet: stm32n6: Fix compilation after refactoring #96845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ClaCodes,
FRASTM,
GeorgeCGV,
decsny,
djiatsaf-st,
etienne-lms,
gautierg-st,
lmajewski,
maass-hamburg,
marwaiehm-st,
mathieuchopstm and
pdgendt
etienne-lms
reviewed
Oct 1, 2025
Phy modes declarations where not correctly placed for use with N6 series. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
Compilers may not like that attributes are provides in actual and extern definitions of symbols. Removing them from extern definitions Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
Rather than symbol coming from the HAL, use zephyr `__aligned()` macro. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
Twister netif:eth was missing on stm32n6 based board and hence they were not build against net samples. Fix this. Additionally, on dk, fix `pwm` to respect alphabetical order. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
|
gautierg-st
approved these changes
Oct 1, 2025
etienne-lms
approved these changes
Oct 1, 2025
maass-hamburg
approved these changes
Oct 1, 2025
mathieuchopstm
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that stm32n6 based boards were not specifying ethernet support for twister and hence were not built/tested vs net susbsystem.
As a consequence they were not taken into account in recent refactoring (#96095) which led to build issues.
Add twister eth support on these boards and fix issues generated by refactoring.